Downgrade KMS SDK to avoid conflicts with TSS dependencies #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the latest version aws-sdk-kms and tss-esapi has a common conflicting transitive dependency. Each of the libraries has different version requirements for that dependency and they don't intersect. To make build successful we align it and downgrade aws-sdk-kms to the version where conflict disappears. Also aws-config dependency is used only for testing and is moved to dev dependencies. Bumping up the successfully buildable package version to publish it to crates.io Signed-off-by: Eugene Koira <[email protected]>
clupuishere
approved these changes
Apr 11, 2024
mariusknaust
approved these changes
Apr 11, 2024
|
On hold for now as @petreeftime proposed an alternative approach and pushing to update |
|
Closing this PR in favor of upgrading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
In the latest version aws-sdk-kms and tss-esapi has a common conflicting transitive dependency. Each of the libraries has different version requirements for that dependency and they don't intersect (Originated from
tss-esapi->mboxversioning hard requirements as described here).To make build successful we align it and downgrade aws-sdk-kms to the version where conflict disappears.
Also aws-config dependency is used only for testing and is moved to dev dependencies.
Bumping up the successfully buildable package version to publish it to crates.io
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.