JavaScript (v3): Add Husky for githook management.

awsdocs · Oct 15, 2024 · e118bcb · e118bcb
1 parent 3432730
commit e118bcb
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 17 deletions.
diff --git a/javascriptv3/hook_scripts/pre-commit.sh → javascriptv3/.husky/pre-commit b/javascriptv3/hook_scripts/pre-commit.sh → javascriptv3/.husky/pre-commit
@@ -1,11 +1,10 @@
-#!/bin/bash
 # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 # SPDX-License-Identifier: Apache-2.0
 
 set -e
 
 # Lint
-npm run lint
+npm run --prefix ./javascriptv3 lint
 
 # Test
-npm test
+npm test --prefix ./javascriptv3
diff --git a/javascriptv3/github_scripts/lint.sh b/javascriptv3/github_scripts/lint.sh
@@ -2,16 +2,4 @@
 # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 # SPDX-License-Identifier: Apache-2.0
 
-# Filter out JSON files
-filtered_files=()
-for file in "$@"; do
- if [[ "$file" != *"javascriptv3/"*.json ]]; then
- filtered_files+=("$file")
- fi
-done
-
-# Run linting only on filtered files
-npm run --prefix javascriptv3 ci-lint -- "${filtered_files[@]//javascriptv3\/}"
-
-# Run format check
-npm run --prefix javascriptv3 ci-format-check -- "${@//javascriptv3\/}"
+npm run --prefix javascriptv3 ci-lint
diff --git a/javascriptv3/package.json b/javascriptv3/package.json
@@ -7,7 +7,8 @@
  "merge-test-results": "jrm test-results.xml \"**/test_results/**/*.junit.xml\"",
  "log-tests": "cat test-results.xml",
  "lint": "lint-staged",
- "ci-lint": "biome check"
+ "ci-lint": "biome check",
+ "prepare": "cd .. && husky javascriptv3/.husky"
  },
  "lint-staged": {
  "*.{js,ts,jsx,tsx}": ["biome format --write", "biome lint"],
@@ -68,6 +69,7 @@
  ],
  "devDependencies": {
  "@biomejs/biome": "1.9.3",
+ "husky": "^9.1.6",
  "junit-report-merger": "^7.0.0",
  "lint-staged": "^14.0.1",
  "typescript": "^5.2.2",