Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update ubuntu versions #4828

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

boquan-fang
Copy link
Contributor

@boquan-fang boquan-fang commented Oct 8, 2024

Resolved issues:

Update Ubuntu versions for new Valgrind checks to Ubuntu 24. Resolve #4759.

Description of changes:

  • Update test ubuntu version for valgrind check with AWSLC to 24.

Call-outs:

  • Padentic valgrind check is not updated because of this reason.
  • Valgrind in Ubuntu 22 can't read unit test debug info if compiled with AWSLC
    • AWSLC 1.36.0 is compiled with Clang in docker. Valgrind in Ubuntu 22 can't exam Clang-compiled executable.
    • Valgrind in Ubuntu 24 can read Clang-compiled executable, so upgrade Ubuntu versions to 24 is the fix.
  • We will leave the rest to run on Ubuntu 22, since we still want some coverages on that platform.
  • We can add Clang compiled executable to the Valgrind checks in the future.
  • We should gradually update the ubuntu versions to 24 for other tests.

Testing:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* update tests ubuntu versions to 24 except padentic valgrind check
* use Ubuntu 22 for openssl 1.0.2 and 3.0 tests
@boquan-fang boquan-fang enabled auto-merge (squash) October 11, 2024 21:33
@boquan-fang boquan-fang merged commit 6ca63e4 into aws:main Oct 12, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Valgrind version in CI docker image
3 participants