chore(GHA): allow OIDC aws credentials #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Wesley Rosenblum <[email protected]>
WesleyRosenblum
previously approved these changes
Oct 16, 2024
WesleyRosenblum
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
n/a
Description of changes:
Similar to the change for s2n-tls, update the use of AWS credentials from GitHub secrets to OpenID Connect.
Call-outs:
This also includes a change to the Duvet action that will need to be merged in coordinated with an update to the s2n-tls workflow aws/s2n-tls#4850
The publish to public ECR needs more work and will be in a future PR.
Testing:
How was this change tested ? in the s2n-netbench repo. Changes based on this doc
In this PR, you can see a successful use of the OIDC auth in the
book/deployaction, on the aws auth step of the workflow, note theAssuming role with OIDCsuccess message.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.