Update Custom Scheduler Documentation and Deployment Method #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add information on WaitForFirstConsumer and Immediate binding modes - Provide examples for creating storage classes for both modes - Update Spark configuration examples for dynamic provisioning - Improve documentation with warnings and info notes for clarity - Refine explanations for EBS volume attachment in different scenarios
- Remove Docker-specific commands from preBootstrapCommands - Adjust permissions for /var/lib/kubelet - Simplify NVMe disk mounting process for EKS nodes
- Replace manual kubectl apply with Helm chart deployment - Update EKS version and kube-scheduler image information - Add table for kube-scheduler images across different EKS versions - Remove lengthy YAML manifest in favor of Helm chart - Add instructions for downloading source code and deploying with Helm - Enable table support in mkdocs.yml This change simplifies the deployment process for custom schedulers and provides more up-to-date information on EKS versions and corresponding kube-scheduler images.
lmouhib
requested changes
Oct 8, 2024
| @@ -45,332 +45,25 @@ The following customer scheduler named “my-scheduler” is created for EKS ver | |||
|
|
|||
| We do not recommend build the kube-scheduler by yourself, you can leverage the eks-distro kube-scheduler image. For example: | |||
|
|
|||
| - **Amazon EKS 1.28 image:** public.ecr.aws/eks-distro/kubernetes/kube-scheduler:v1.28.11-eks-1-28-latest | |||
| - **Amazon EKS 1.29 image:** public.ecr.aws/eks-distro/kubernetes/kube-scheduler:v1.29.6-eks-1-29-18 | |||
There was a problem hiding this comment.
Can we keep these sections as is, and then add a note/section that point to the helm chart.
The idea is to keep the current level of details to explain what is being done in terms of RBAC, and provide the helm chart as utility to simplify the deployment.
lmouhib
requested changes
Oct 8, 2024
content/storage/docs/spark/ebs.md
Outdated
| @@ -146,36 +147,135 @@ kubectl get pod <driver pod name> -n <namespace> -o yaml --export | |||
|
|
|||
| ### Dynamic Provisioning | |||
|
|
|||
| Dynamic Provisioning PVC/Volumes is supported for both Spark driver and executors for EMR versions >= 6.3.0. | |||
| EMR versions 6.3.0 and newer support dynamic provisioning of PVC/Volumes for both Spark driver and executors. | |||
There was a problem hiding this comment.
There is another PR for EBS, can you please remove it from this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Custom Scheduler Documentation and Deployment Method
Changes Made
kubectl applydeployment with Helm chart deployment for the custom schedulerReason for Changes
These updates simplify the deployment process for custom schedulers and provide more up-to-date information on EKS versions and corresponding kube-scheduler images. Using a Helm chart makes it easier for users to deploy and manage the custom scheduler, reducing the likelihood of errors and improving maintainability.
Testing and Validation
Additional Notes
Please review these changes and provide any feedback or suggestions for improvement.