-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Custom Scheduler Documentation and Deployment Method #59
base: main
Are you sure you want to change the base?
Update Custom Scheduler Documentation and Deployment Method #59
Conversation
- Add information on WaitForFirstConsumer and Immediate binding modes - Provide examples for creating storage classes for both modes - Update Spark configuration examples for dynamic provisioning - Improve documentation with warnings and info notes for clarity - Refine explanations for EBS volume attachment in different scenarios
- Remove Docker-specific commands from preBootstrapCommands - Adjust permissions for /var/lib/kubelet - Simplify NVMe disk mounting process for EKS nodes
- Replace manual kubectl apply with Helm chart deployment - Update EKS version and kube-scheduler image information - Add table for kube-scheduler images across different EKS versions - Remove lengthy YAML manifest in favor of Helm chart - Add instructions for downloading source code and deploying with Helm - Enable table support in mkdocs.yml This change simplifies the deployment process for custom schedulers and provides more up-to-date information on EKS versions and corresponding kube-scheduler images.
@@ -45,332 +45,25 @@ The following customer scheduler named “my-scheduler” is created for EKS ver | |||
|
|||
We do not recommend build the kube-scheduler by yourself, you can leverage the eks-distro kube-scheduler image. For example: | |||
|
|||
- **Amazon EKS 1.28 image:** public.ecr.aws/eks-distro/kubernetes/kube-scheduler:v1.28.11-eks-1-28-latest | |||
- **Amazon EKS 1.29 image:** public.ecr.aws/eks-distro/kubernetes/kube-scheduler:v1.29.6-eks-1-29-18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep these sections as is, and then add a note/section that point to the helm chart.
The idea is to keep the current level of details to explain what is being done in terms of RBAC, and provide the helm chart as utility to simplify the deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
content/storage/docs/spark/ebs.md
Outdated
@@ -146,36 +147,135 @@ kubectl get pod <driver pod name> -n <namespace> -o yaml --export | |||
|
|||
### Dynamic Provisioning | |||
|
|||
Dynamic Provisioning PVC/Volumes is supported for both Spark driver and executors for EMR versions >= 6.3.0. | |||
EMR versions 6.3.0 and newer support dynamic provisioning of PVC/Volumes for both Spark driver and executors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another PR for EBS, can you please remove it from this PR.
Update Custom Scheduler Documentation and Deployment Method
Changes Made
kubectl apply
deployment with Helm chart deployment for the custom schedulerReason for Changes
These updates simplify the deployment process for custom schedulers and provide more up-to-date information on EKS versions and corresponding kube-scheduler images. Using a Helm chart makes it easier for users to deploy and manage the custom scheduler, reducing the likelihood of errors and improving maintainability.
Testing and Validation
Additional Notes
Please review these changes and provide any feedback or suggestions for improvement.