Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore symlinks if they are in in .ebignore #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ignore symlinks if they are in in .ebignore #91

wants to merge 1 commit into from

Conversation

vince1995
Copy link

fixes #69

@alexd2580-sf
Copy link

I have my ebcli inside a folder in the repo.
The ebcli folder is ignored within the .ebignore as

ebcli
ebcli/
ebcli/*

With this patch the ebcli/lib64 symling is still included.
To remove it i need to explicitly ignore ebcli/lib64 (and all other symlinks).

IMO ignoring ebcli should suffice to not even include the folder itself (much less its content).

@vince1995
Copy link
Author

Yeah, that's correct. I'm not a python developer and stuck at this piece of code I wrote for an hour. I know that this solution is not optimal but it's working for my team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.ebignore includes symlinked files in ignored directories
2 participants
@vince1995 @alexd2580-sf