Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a Unit Test Bug #207

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Fixed a Unit Test Bug #207

merged 2 commits into from
Sep 23, 2022

Conversation

yohanthshetty
Copy link
Contributor

Overview:
.ebignore includes symlinked files in ignored directories
Fixed Issue#69

Description of changes:
Fixed bug where a folder mentioned in .ebignore file was being included in the final code.zip on running eb deploy. This was due to the presence of a symlink within that folder.

Changes

  1. Added method to check if current file being checked for ignore/include exists in the ignore_list.
  2. Updated the Pathspec library to latest version i.e. 0.10.1
  3. Changed method in get_ebignore_list() function from match_tree to math_tree_entries.

.ebignore contents = ignore/ , Before: we were getting ignore/.... but not just ignore/ After: we get ignore/... and just ignore/ too.

  1. Updated Unit test case.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.ebignore includes symlinked files in ignored directories
1 participant