Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue69 #202

Closed
wants to merge 8 commits into from
Closed

Issue69 #202

wants to merge 8 commits into from

Conversation

yohanthshetty
Copy link
Contributor

@yohanthshetty yohanthshetty commented Sep 19, 2022

Issue 69: .ebignore includes symlinked files in ignored directories #69

Description of changes:

Overview:

Regarding issue: #69

Fixed bug where a folder mentioned in .ebignore file was being included in the final code.zip on running eb deploy. This was due to the presence of a symlink within that folder.

Changes

  1. Added a method to check if the current file/directory being checked for ignore/include exists in the ignore_list.
  2. Updated Pathspec library to latest version i.e. 0.10.1
  3. Changed method in get_ebignore_list() function from match_tree to math_tree_entries.
  4. Updated Unit test case.

@Mickeypeng Mickeypeng closed this Sep 19, 2022
@Mickeypeng
Copy link
Contributor

Close PR after discussed with Yohanth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants