fix: Add -i flag to ignore not known sysctl properties on macOS #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
Aug 25, 2022
| @@ -27,7 +27,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| sysctlCmd = "sysctl" | |||
| sysctlCmd = "sysctl -i" | |||
There was a problem hiding this comment.
"-i" would go in the args list in collectPlatformDependentInstanceData which is passed as a list. https://github.com/aws/amazon-ssm-agent/pull/465/files#diff-778168ecc0be5e5a65af22002b8f54dbf8396a2cef118de7ea820a5c5c5190f3R53
There was a problem hiding this comment.
Thanks for the review, fixed.
There was a problem hiding this comment.
Can we merge this @justinmk3?
There was a problem hiding this comment.
I don't have merge rights here. I'll pass this along to the team.
zaremba-tomasz
force-pushed
the
fix/ignore-unknown-sysctl-oid
branch
from
73bbfa5
to
06a956e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #464 *
Description of changes:
Add
-iflag tosysctlcall to ignore not recognizedoidon M1 chip based Macs.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.