Exposing summary_view lookback period in a parameter #958
+23
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iakov-aws
reviewed
Oct 2, 2024
| Type: String | ||
| Description: Number of months of data to capture in summary_view (used on most visuals). Valid range 7 to 24. Default=7 (6 past + 1 current). More months will require more Spice capacity in QuickSight. | ||
| Default: "7" | ||
| AllowedPattern: '\b(0?[7-9]|1[0-9]|2[0-4])\b' |
There was a problem hiding this comment.
I was thinking we need an upper limit. Picked two years. You think we should not have one?
iakov-aws
reviewed
Oct 2, 2024
| @@ -61,6 +61,8 @@ Metadata: | |||
| default: "Deploy KPI Dashboard" | |||
| OptimizationDataCollectionBucketPath: | |||
| default: "Path to Optimization Data Collection S3 bucket" | |||
| MonthsLookback: | |||
There was a problem hiding this comment.
This only affects summary view, right? Not sure what what would be a right name here.
- SummaryViewDefaultMonthLimit ?
- DefaultMonthLimit ?
Also need to make it clear that updating of this parameter wont update the views/datasets/dashboards
yprikhodko
reviewed
Oct 2, 2024
| @@ -61,6 +61,8 @@ Metadata: | |||
| default: "Deploy KPI Dashboard" | |||
| OptimizationDataCollectionBucketPath: | |||
| default: "Path to Optimization Data Collection S3 bucket" | |||
| MonthsLookback: | |||
| default: "Number of months to lookback in summary_view" | |||
There was a problem hiding this comment.
Another topic is days to loopback in resource_view and hourly_view. Currently 30 but customers ask to control it as well
There was a problem hiding this comment.
I'll look into that as well. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.