Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

release: 0.15.0 #37

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

superwerker-bot
Copy link
Contributor

Hey @davmayd @troy-ameigh, please take a look at the most recent release:

https://github.com/superwerker/superwerker/releases/tag/v0.15.0

@skomp
Copy link

skomp commented Feb 16, 2023

@vsnyc @tonynv @tlindsay42 @andrew-glenn @troy-ameigh

Hey folks, we are currently intensifying our work regarding superwerker. We just migrated everything to CDK and now only have one template.
We believe that the "Validates files are CFN" status check is behaving weirdly. What can we do here?
Our analysis shows that there are issues in the respective linter. All our resources are matching the type regex. The regex check is performed the wrong way around and also would only check the first resource if it matches.

@troy-ameigh
Copy link
Contributor

troy-ameigh commented Feb 17, 2023

Are you synthizing the templates and then running CFN-Lint. What do you get when you run CDK-Nag(https://github.com/cdklabs/cdk-nag) Can you try that and see what you get also we require this to be added in the test, as per the readme. Also if you want to move to CDK I think we should have sync call. We have setup a call.

@troy-ameigh
Copy link
Contributor

@skomp Since it appears you are synthesizing the temple, it has removed the "AWSTemplateFormatVersion: 2010-09-09" line, which will cause this check to fail. We have setup a call for Monday, however I don't have your email to include you, we included @s0enke. Can you please pass it to me, so I can add you to the call. For our publishing, if you are moving to CDK we would want to publish the CDK code and not a synthesized template.

@skomp
Copy link

skomp commented Feb 20, 2023

Hey @troy-ameigh, @bracki already invited me :) Thank you very much. Looking forward to the call.

@bracki bracki requested a review from a team as a code owner March 17, 2023 11:10
@bracki
Copy link

bracki commented Mar 17, 2023

OK, the linter is green. We'll close this branch and cut a fresh release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants