Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Service-specific ACKAddOns #978

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Feature] Service-specific ACKAddOns #978

wants to merge 3 commits into from

Commits on Apr 5, 2024

  1. Adding service-specific ACKAddOn classes 

    - Added a service-specific ACKAddOn class per all AWS services in serviceMappings to allow ARM support of ACK services that support ARM
- Added unit tests for service-specific ACKAddOns S3 (supports all platforms) & MemoryDB (only serviceMappings service which does not support ARM)
- Added service-specific ACKAddOn classes as exports of ack/index.ts
    @dwright20
    dwright20 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    b5f5f78 View commit details
    Browse the repository at this point in the history

  2. adding missed services, making tests more robust, & making namespace … 

    …creation more robust

- Kinesis & KMS annotations were missed & are now added
- Improved tests so that it covers all service-specific addons
- Added test to confirm it will error if an addon with an unsupported architect and supported architecture are added to the same build
- Modified createNamespace logic to check if the addon namespace exists before attempting to create it
    @dwright20
    dwright20 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    29978fb View commit details
    Browse the repository at this point in the history

  3. reverting additional logic added to createNamespace 

    logic was added as test for adding multiple ACKAddOns was failing as both addons were trying to create the same namespace. It was most likely an intentional design choice for the user to override the default prop to create namespace, as the prop comment mentions it. Modified test so that only the first ACKAddOn added to the list spefies to create namespace and others do not
    @dwright20
    dwright20 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    7537400 View commit details
    Browse the repository at this point in the history