Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurations of OpenTelemetryCollector and AMP Rules for AmpAddOn #796

Merged

Conversation

freschri
Copy link
Collaborator

@freschri freschri commented Aug 1, 2023

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@elamaran11
Copy link
Collaborator

Hi @freschri Thankyou for the PR. I think you might have to close the PR and reopen a new PR for same branch after rebase. I think you are showing changes from many previous PRs merged. Could you please fix that and let us know. I also for some reason dont see your changes for AMP in this PR.

@elamaran11 elamaran11 merged commit f4e2999 into 783-opentelemetrycollector-customisation-for-ampaddon Aug 1, 2023
17 checks passed
@freschri
Copy link
Collaborator Author

freschri commented Aug 2, 2023

Hi @freschri Thankyou for the PR. I think you might have to close the PR and reopen a new PR for same branch after rebase. I think you are showing changes from many previous PRs merged. Could you please fix that and let us know. I also for some reason dont see your changes for AMP in this PR.

created new one as requested: #801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants