fix: use canoncial for staging and content #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urvashijain18
approved these changes
Nov 12, 2021
abanthiy
reviewed
Nov 12, 2021
| if (!contentPath.toFile().getAbsolutePath().startsWith(stagingPath.toAbsolutePath().toString())) { | ||
| final String contentCanonical = contentPath.toFile().getCanonicalPath(); | ||
| final String stagingCanonical = stagingPath.toFile().getCanonicalPath(); | ||
| if (!contentCanonical.startsWith(stagingCanonical)) { |
There was a problem hiding this comment.
I remember Urvashi facing an issue in windows tests , so we switched to absolute path. We should verify this works on windows before merging this in
There was a problem hiding this comment.
@urvashijain18 has confirmed that this works for both Mac (host) and Windows (DUT), so I think we're good here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fortify caught this code path again.
Description of changes:
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.