fix: enforce jackson version dependency to exclude correct duplicate #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit Tests Coverage Report for aws-greengrass-testing-features
Minimum allowed coverage is Generated by 🐒 cobertura-action against 2ad4c0f |
|
Unit Tests Coverage Report for aws-greengrass-testing-launcher
Minimum allowed coverage is Generated by 🐒 cobertura-action against 2ad4c0f |
|
Unit Tests Coverage Report for aws-greengrass-testing-platform-api
Minimum allowed coverage is Generated by 🐒 cobertura-action against 2ad4c0f |
|
Unit Tests Coverage Report for aws-greengrass-testing-platform-pillbox
Minimum allowed coverage is Generated by 🐒 cobertura-action against 2ad4c0f |
MikeDombo
previously approved these changes
Nov 3, 2023
saranyailla
previously approved these changes
Nov 3, 2023
urvashijain18
previously approved these changes
Nov 3, 2023
patrzhan
dismissed stale reviews from urvashijain18, saranyailla, and MikeDombo
via
2ad4c0f
MikeDombo
approved these changes
Nov 3, 2023
urvashijain18
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add jackson-core to the pom.xml for aws-greengrass-testing-examples-component. This is placed above the iotdevicesdk dependency which will otherwise create a dependency on jackson 2.12.0 which conflicts with the version of jackson we do want.
Why is this change necessary:
When running the existing tests, I would always get a NoSuchMethodError for aws-greengrass-testing-examples-component. This is due to iotdevicesdk jar taking on a transitive dependency on jackson 2.12.0, which in turn excludes the 2.15.2 version of jackson that the project is actually trying to use as there is a conflict. This results in the NoSuchMethodError as the wrong jackson version is being used.
How was this change tested:
The tests that were previously failing out-of-box are able to run and pass with this change.
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.