Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update aws sdk dependency #226

Merged
merged 1 commit into from
Oct 2, 2023
Merged

chore: update aws sdk dependency #226

merged 1 commit into from
Oct 2, 2023

Conversation

saranyailla
Copy link
Member

@saranyailla saranyailla commented Oct 2, 2023

Issue #, if available:

Description of changes:

  • Bump the AWS SDK version to latest.
  • Use versions-maven-plugin to identify and update the aws java sdk version to latest in the pom.xml file using update-properties goal.
  • This plugin automatically updates the sdk version in the pom.xml when the project is built locally (using mvn install). Developers have to still commit the changes.
  • If the SDK version in the pom.xml is not the latest one available, the GitHub workflow fails (as it tries to update the pom.xml but fails as it doesn't have the permissions to update the file). If there's no update, the build step completes successfully.

Why is this change necessary:

How was this change tested:

Any additional information or context required to review the change:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Unit Tests Coverage Report for aws-greengrass-testing-features

File Coverage Lines Branches
All files 32% 39% 25%
com.aws.greengrass.testing.model.TestContextModel 0% 0% 0%
com.aws.greengrass.testing.model.RegistrationContextModel 0% 0% 0%
com.aws.greengrass.testing.model.ScenarioContext 64% 70% 57%
com.aws.greengrass.testing.model.GreengrassContextModel 25% 25% 0%
com.aws.greengrass.testing.component.RecipeComponentPreparationService$1 100% 100% 0%
com.aws.greengrass.testing.component.LocalComponentPreparationService$1 100% 100% 0%
com.aws.greengrass.testing.component.CloudComponentPreparationService 32% 39% 25%
com.aws.greengrass.testing.component.ClasspathComponentPreparationService 100% 100% 0%
com.aws.greengrass.testing.component.FileComponentPreparationService 100% 100% 0%
com.aws.greengrass.testing.component.CompositeComponentPreparationService 100% 100% 0%
com.aws.greengrass.testing.component.PreparationServiceUtils 10% 10% 0%
com.aws.greengrass.testing.component.LocalComponentPreparationService 59% 56% 63%
com.aws.greengrass.testing.component.RecipeComponentPreparationService 48% 53% 44%
com.aws.greengrass.testing.util.EncryptionUtils 0% 0% 0%
com.aws.greengrass.testing.util.EncryptionUtils$PemWriter 0% 0% 0%
com.aws.greengrass.testing.features.DeploymentSteps 25% 38% 13%
com.aws.greengrass.testing.features.GreengrassSteps 100% 100% 0%
com.aws.greengrass.testing.features.FileSteps$ByteNotation 0% 0% 0%
com.aws.greengrass.testing.features.FileSteps 11% 11% 0%
com.aws.greengrass.testing.features.WaitSteps 55% 73% 38%
com.aws.greengrass.testing.features.IotSteps 44% 44% 0%
com.aws.greengrass.testing.features.IamSteps 0% 0% 0%
com.aws.greengrass.testing.features.AWSResourcesSteps 0% 0% 0%
com.aws.greengrass.testing.features.DeploymentSteps$2 0% 0% 0%
com.aws.greengrass.testing.features.DeploymentSteps$1 100% 100% 0%
com.aws.greengrass.testing.features.NetworkUtilsSteps 0% 0% 0%
com.aws.greengrass.testing.features.DeploymentSteps$3 100% 100% 0%
com.aws.greengrass.testing.features.S3Steps 72% 94% 50%
com.aws.greengrass.testing.features.RegistrationSteps 34% 40% 28%
com.aws.greengrass.testing.features.GreengrassCliSteps 60% 69% 50%
com.aws.greengrass.testing.features.LoggerSteps 0% 0% 0%
com.aws.greengrass.testing.DefaultGreengrass 54% 69% 38%
com.aws.greengrass.testing.modules.HsmParameters 0% 0% 0%
com.aws.greengrass.testing.modules.FeatureParameters 0% 0% 0%

Minimum allowed coverage is 60%

Generated by 🐒 cobertura-action against 64b7c07

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Unit Tests Coverage Report for aws-greengrass-testing-launcher

File Coverage Lines Branches
All files 65% 76% 53%
com.aws.greengrass.testing.launcher.reporting.StepTrackingReporting 49% 62% 36%
com.aws.greengrass.testing.launcher.utils.CucumberReportUtils 95% 100% 90%
com.aws.greengrass.testing.launcher.ParallelizationConfig 100% 100% 0%
com.aws.greengrass.testing.launcher.TestLauncherParameterValues 0% 0% 0%
com.aws.greengrass.testing.launcher.TestLauncherParameters 100% 100% 0%

Minimum allowed coverage is 60%

Generated by 🐒 cobertura-action against 64b7c07

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Unit Tests Coverage Report for aws-greengrass-testing-platform-api

File Coverage Lines Branches
All files 45% 34% 56%
com.aws.greengrass.testing.platform.windows.WindowsNetworkUtils 0% 0% 0%
com.aws.greengrass.testing.platform.windows.WindowsPlatform 75% 75% 0%
com.aws.greengrass.testing.platform.windows.WindowsNetworkUtils$1 0% 0% 0%
com.aws.greengrass.testing.platform.windows.WindowsCommands 43% 36% 50%
com.aws.greengrass.testing.platform.macos.MacosNetworkUtils 0% 0% 0%
com.aws.greengrass.testing.platform.macos.MacosCommands 96% 100% 92%
com.aws.greengrass.testing.platform.macos.MacosPlatform 75% 75% 0%
com.aws.greengrass.testing.platform.linux.LinuxNetworkUtils 0% 0% 0%
com.aws.greengrass.testing.platform.linux.LinuxCommands 100% 100% 0%
com.aws.greengrass.testing.platform.linux.LinuxPlatform 75% 75% 0%
com.aws.greengrass.testing.platform.AbstractPlatform 100% 100% 0%
com.aws.greengrass.testing.platform.PlatformResolver 96% 100% 92%
com.aws.greengrass.testing.platform.RemoteFiles 15% 15% 0%
com.aws.greengrass.testing.platform.LocalFiles 61% 71% 50%
com.aws.greengrass.testing.platform.NetworkUtils 0% 0% 0%
com.aws.greengrass.testing.platform.UnixPathsMixin 0% 0% 0%
com.aws.greengrass.testing.platform.UnixCommands 7% 7% 0%
com.aws.greengrass.testing.platform.DevicePredicatePlatformFiles 28% 28% 0%
com.aws.greengrass.testing.platform.NucleusInstallationParametersModel 0% 0% 0%
com.aws.greengrass.testing.platform.Commands 0% 0% 0%
com.aws.greengrass.testing.platform.PlatformFiles 0% 0% 0%

Minimum allowed coverage is 60%

Generated by 🐒 cobertura-action against 64b7c07

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Unit Tests Coverage Report for aws-greengrass-testing-platform-pillbox

File Coverage Lines Branches
All files 66% 67% 65%
com.aws.greengrass.testing.pillbox.commands.files.Exists 100% 100% 100%
com.aws.greengrass.testing.pillbox.commands.files.Mkdir 87% 90% 83%
com.aws.greengrass.testing.pillbox.commands.files.Find 82% 100% 64%
com.aws.greengrass.testing.pillbox.commands.files.Cat 100% 100% 100%
com.aws.greengrass.testing.pillbox.commands.files.Remove 88% 93% 83%
com.aws.greengrass.testing.pillbox.commands.files.Find$Type 89% 93% 86%
com.aws.greengrass.testing.pillbox.Pillbox 0% 0% 0%
com.aws.greengrass.testing.pillbox.commands.Process 0% 0% 0%
com.aws.greengrass.testing.pillbox.commands.Files 0% 0% 0%
com.aws.greengrass.testing.pillbox.commands.process.Descendants 0% 0% 0%

Minimum allowed coverage is 60%

Generated by 🐒 cobertura-action against 64b7c07

@saranyailla saranyailla changed the title chore: update sdk dependency chore: update aws sdk dependency Oct 2, 2023
@saranyailla saranyailla marked this pull request as ready for review October 2, 2023 22:32
@saranyailla saranyailla merged commit 5095919 into main Oct 2, 2023
5 checks passed
@saranyailla saranyailla deleted the sdk-deps branch October 2, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants