-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable s3 dualstack endpoint with deployment #1660
Conversation
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against ac6a9e8 |
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against ac6a9e8 |
Can you be more detailed with the PR description? It's technically not ipv6 support for nucleus; it's just enabling deployment to call S3 dualstack endpoints. Also please also include in PR description what other jvm options are there to enable dualstack endpoints |
Issue #, if available:
Description of changes:
Introduced new config parameter
DUALSTACK
tos3EndpointType
Why is this change necessary:
To fully enable dualstack endpoint, customer need to make a deployment to change the following configurations:
aws.useDualstackEndpoint
totrue
underjvmOptions
. This setting would enable all the http calls made by aws client to point to dualstack endpoints.s3EndpointType
toDUALSTACK
. This configuration will ensure that the pre-signed URLs returned by the AWS Greengrass dataplane API (GetComponentVersionArtifact and GetDeploymentConfiguration APIs) points to dual-stack endpoints for Amazon S3.How was this change tested:
Any additional information or context required to review the change:
Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.