fix: normalize component not found error messages for GetConfiguratio…

…n and UpdateConfiguration
aws-greengrass · Feb 9, 2024 · c391d69 · c391d69
1 parent bc62d52
commit c391d69
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.../java/com/aws/greengrass/builtin/services/configstore/ConfigStoreIPCEventStreamAgent.java b/.../java/com/aws/greengrass/builtin/services/configstore/ConfigStoreIPCEventStreamAgent.java
@@ -193,7 +193,7 @@ public GetConfigurationResponse handleRequest(GetConfigurationRequest request) {
                 Topics serviceTopics = kernel.findServiceTopic(finalServiceName);
 
                 if (serviceTopics == null) {
-                    throw new ResourceNotFoundError(KEY_NOT_FOUND_ERROR_MESSAGE);
+                    throw new ResourceNotFoundError(String.format(COMPONENT_NOT_FOUND_ERROR_FORMAT, finalServiceName));
                 }
 
                 Topics configTopics = serviceTopics.findInteriorChild(CONFIGURATION_CONFIG_KEY);

diff --git a/...a/com/aws/greengrass/builtin/services/configstore/ConfigStoreIPCEventStreamAgentTest.java b/...a/com/aws/greengrass/builtin/services/configstore/ConfigStoreIPCEventStreamAgentTest.java
@@ -222,7 +222,7 @@ void GIVEN_get_config_request_WHEN_component_requested_does_not_exist_THEN_fail(
         request.setKeyPath(Collections.singletonList("AnyKey"));
         ResourceNotFoundError error = assertThrows(ResourceNotFoundError.class, () ->
                 agent.getGetConfigurationHandler(mockContext).handleRequest(request));
-        assertEquals("Key not found", error.getMessage());
+        assertEquals("Component config not found for component WrongComponent", error.getMessage());
     }
 
     @Test