Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve LogFileGroup error message on hardlink failure #211

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

frehov
Copy link
Contributor

@frehov frehov commented Aug 16, 2023

Issue #, if available:

Description of changes:
Clarifying that LogManager is falling back to using regular files.

Why is this change necessary:
The logged error message does not make it clear that the log manager is falling back to regular files, only that it is falling

How was this change tested:
It's not

Any additional information or context required to review the change:

Checklist:

  • Updated the README if applicable
  • Updated or added new unit tests
  • Updated or added new integration tests
  • Updated or added new end-to-end tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jcosentino11
Copy link
Member

Thanks for the pr! Please update the commit and pr title to follow "conventional commit" format

@frehov frehov changed the title Improve LogFileGroup error message on hardlink failure fix: Improve LogFileGroup error message on hardlink failure Aug 16, 2023
@frehov
Copy link
Contributor Author

frehov commented Aug 16, 2023

Thanks for the pr! Please update the commit and pr title to follow "conventional commit" format

Updated title and commit to the best of my abilities

@jcosentino11
Copy link
Member

@frehov ✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case] think it doesn't like uppercase in Improve

Clarifying that LogManager is `falling back` to using regular files.
@frehov frehov changed the title fix: Improve LogFileGroup error message on hardlink failure fix: improve LogFileGroup error message on hardlink failure Aug 17, 2023
@frehov
Copy link
Contributor Author

frehov commented Aug 17, 2023

@frehov ✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case] think it doesn't like uppercase in Improve

alright, should be fixed now

@github-actions
Copy link

Unit Tests Coverage Report

File Coverage Lines Branches
All files 77% 84% 71%
com.aws.greengrass.logmanager.services.DiskSpaceManagementService 71% 83% 60%
com.aws.greengrass.logmanager.CloudWatchLogsUploader 90% 97% 83%
com.aws.greengrass.logmanager.LogManagerService 67% 81% 54%
com.aws.greengrass.logmanager.LogManagerService$CurrentProcessingFileInformation 79% 89% 68%
com.aws.greengrass.logmanager.PositionTrackingBufferedReader 86% 87% 86%
com.aws.greengrass.logmanager.CloudWatchAttemptLogsProcessor 90% 93% 87%
com.aws.greengrass.logmanager.util.ConfigUtil 85% 85% 85%
com.aws.greengrass.logmanager.util.CloudWatchClientFactory 53% 53% 0%
com.aws.greengrass.logmanager.model.CloudWatchAttemptLogInformation 100% 100% 0%
com.aws.greengrass.logmanager.model.EventType 100% 100% 0%
com.aws.greengrass.logmanager.model.ProcessingFiles 68% 80% 56%
com.aws.greengrass.logmanager.model.ComponentType 100% 100% 0%
com.aws.greengrass.logmanager.model.LogFile 86% 81% 92%
com.aws.greengrass.logmanager.model.LogFileGroup 70% 75% 64%

Minimum allowed coverage is 65%

Generated by 🐒 cobertura-action against 64c3a9e

@github-actions
Copy link

Integration Tests Coverage Report

File Coverage Lines Branches
All files 73% 80% 67%
com.aws.greengrass.logmanager.services.DiskSpaceManagementService 73% 77% 70%
com.aws.greengrass.logmanager.CloudWatchLogsUploader 45% 48% 41%
com.aws.greengrass.logmanager.LogManagerService 85% 94% 75%
com.aws.greengrass.logmanager.LogManagerService$CurrentProcessingFileInformation 46% 55% 37%
com.aws.greengrass.logmanager.PositionTrackingBufferedReader 72% 82% 63%
com.aws.greengrass.logmanager.CloudWatchAttemptLogsProcessor 72% 78% 66%
com.aws.greengrass.logmanager.util.ConfigUtil 76% 73% 78%
com.aws.greengrass.logmanager.util.CloudWatchClientFactory 100% 100% 0%
com.aws.greengrass.logmanager.model.CloudWatchAttemptLogInformation 100% 100% 0%
com.aws.greengrass.logmanager.model.EventType 100% 100% 0%
com.aws.greengrass.logmanager.model.ProcessingFiles 88% 95% 81%
com.aws.greengrass.logmanager.model.ComponentType 100% 100% 0%
com.aws.greengrass.logmanager.model.LogFile 59% 65% 53%
com.aws.greengrass.logmanager.model.LogFileGroup 71% 78% 64%

Minimum allowed coverage is 58%

Generated by 🐒 cobertura-action against 64c3a9e

@MikeDombo MikeDombo merged commit bd631de into aws-greengrass:main Aug 17, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants