-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve LogFileGroup error message on hardlink failure #211
Conversation
Thanks for the pr! Please update the commit and pr title to follow "conventional commit" format |
Updated title and commit to the best of my abilities |
@frehov |
Clarifying that LogManager is `falling back` to using regular files.
alright, should be fixed now |
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 64c3a9e |
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 64c3a9e |
Issue #, if available:
Description of changes:
Clarifying that LogManager is
falling back
to using regular files.Why is this change necessary:
The logged error message does not make it clear that the log manager is
falling back
to regular files, only that it isfalling
How was this change tested:
It's not
Any additional information or context required to review the change:
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.