chore(fips): update endpoint overwrite method #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yitingb
force-pushed
the
fips
branch
2 times, most recently
from
b4ba0a7
to
46aff56
Compare
saranyailla
changed the title
junfuchen99
previously approved these changes
Aug 9, 2024
saranyailla
reviewed
Aug 9, 2024
| @@ -260,6 +266,8 @@ void GIVEN_clientConnectsWhileOnline_WHEN_offlineAndCertificateRevoked_THEN_back | |||
| void GIVEN_clientConnectsWhileOnline_WHEN_offlineAndCertDetachedFromThing_THEN_backOnlineAndClientRejected( | |||
| ExtensionContext context) throws Exception { | |||
| ignoreExceptionOfType(context, NoSuchFileException.class); | |||
| ignoreExceptionOfType(context, MqttRequestException.class); | |||
| ignoreExceptionOfType(context, ExecutionException.class); | |||
There was a problem hiding this comment.
Nit: we can assert the exception as well.
saranyailla
previously approved these changes
Aug 9, 2024
|
Code Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 3c20354 |
Benchmark Results
|
saranyailla
approved these changes
Aug 9, 2024
junfuchen99
approved these changes
Aug 9, 2024
junfuchen99
pushed a commit
that referenced
this pull request
Aug 9, 2024
(cherry picked from commit 27ef646)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Why is this change necessary:
It's used to support fips feature where the endpoint should be override earlier than built-in useFips function
How was this change tested:
With UAT
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.