perf: speed-up policy evaluation #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Results
|
|
We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them. |
|
Code Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 3d67e1f |
|
2 megaops/s seems good enough :) |
MikeDombo
reviewed
Feb 3, 2024
Comment on lines
60
to
74
| Operation op; | ||
| try { | ||
| op = parseOperation(request.getOperation()); | ||
| } catch (PolicyException e) { | ||
| logger.atError().setCause(e).log(); | ||
| return false; | ||
| } | ||
|
|
||
| Resource rsc; | ||
| try { | ||
| rsc = parseResource(request.getResource()); | ||
| } catch (PolicyException e) { | ||
| logger.atError().setCause(e).log(); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
nit: these two try can be combined.
| @@ -119,6 +130,7 @@ private boolean compareOperation(Operation requestOperation, String policyOperat | |||
| if (requestOperation.getOperationStr().equals(policyOperation)) { | |||
| return true; | |||
| } | |||
| // TODO | |||
There was a problem hiding this comment.
yeah to replace string formats, will take care of those now
src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java
Show resolved
Hide resolved
src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java
Show resolved
Hide resolved
| throw new PolicyException(EXCEPTION_MALFORMED_RESOURCE); | ||
| } | ||
|
|
||
| String resourceName = typeAndName.substring(split + 1); |
MikeDombo
reviewed
Feb 6, 2024
| * @param end substring end, | ||
| * @return substring | ||
| */ | ||
| private static String safeSubstring(@NonNull String str, int start, int end) { |
There was a problem hiding this comment.
nonnull will throw if it is null. Is that what you want?
There was a problem hiding this comment.
Is this really any safer or just not doing what you expect it to do. This seems more confusing to me than helpful IMO
There was a problem hiding this comment.
Maybe just needs a rename: "substringWhenInBounds" for example
There was a problem hiding this comment.
if it's more confusing doesn't seem worth it, will just add checking inline
There was a problem hiding this comment.
done, also added more tests
MikeDombo
reviewed
Feb 6, 2024
src/main/java/com/aws/greengrass/clientdevices/auth/PermissionEvaluationUtils.java
Show resolved
Hide resolved
MikeDombo
approved these changes
Feb 6, 2024
sameerzuberi
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
So far these changes provide roughly a ~2x speedup. Still using regex for the resource name to match, as emulating
Pattern.UNICODE_CHARACTER_CLASSbehavior looks to be very complicated, otherwise we would have gotten closer to a ~4x speedup on the benchmarks.Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.