Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(uat): use CURRENT for classpath component in second deployments #398

Merged
merged 2 commits into from
Aug 25, 2023
Merged

fix(uat): use CURRENT for classpath component in second deployments #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d4eb03
fix(uat): use CURRENT for classpath component in second deployments
bgklika Aug 24, 2023
da7dabf
docs(uat): resolve issues related to javadoc generation
bgklika Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ontrol/src/main/java/com/aws/greengrass/testing/mqtt/client/control/api/AgentControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ ConnectionControl createMqttConnection(@NonNull MqttConnectRequest connectReques
* Shutdown whole agent.
*
* @param reason shutdown reason
* @throws StatusRuntimeException on errors
* @throws io.grpc.StatusRuntimeException on errors
*/
void shutdownAgent(String reason);

Expand All @@ -103,7 +103,7 @@ ConnectionControl createMqttConnection(@NonNull MqttConnectRequest connectReques
*
* @param discoveryRequest the request with clients name and credentials
* @return the reply with connectivity information of IoT Core device broker
* @throws StatusRuntimeException on errors
* @throws io.grpc.StatusRuntimeException on errors
*/
CoreDeviceDiscoveryReply discoveryCoreDevice(@NonNull CoreDeviceDiscoveryRequest discoveryRequest);
}
14 changes: 7 additions & 7 deletions ...l/src/main/java/com/aws/greengrass/testing/mqtt/client/control/api/ConnectionControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public interface ConnectionControl {
* @param subscriptionId optional subscription id
* @param subscriptions MQTT subscriptions
* @return reply to subscribe
* @throws StatusRuntimeException on errors
* @throws io.grpc.StatusRuntimeException on errors
*/
default MqttSubscribeReply subscribeMqtt(Integer subscriptionId, @NonNull Mqtt5Subscription... subscriptions) {
final List<Mqtt5Properties> userProperties = null;
Expand All @@ -88,7 +88,7 @@ default MqttSubscribeReply subscribeMqtt(Integer subscriptionId, @NonNull Mqtt5S
* @param userProperties optional MQTT v5.0 user properties
* @param subscriptions MQTT subscriptions
* @return reply to subscribe
* @throws StatusRuntimeException on errors
* @throws io.grpc.StatusRuntimeException on errors
*/
MqttSubscribeReply subscribeMqtt(Integer subscriptionId, List<Mqtt5Properties> userProperties,
@NonNull Mqtt5Subscription... subscriptions);
Expand All @@ -98,7 +98,7 @@ MqttSubscribeReply subscribeMqtt(Integer subscriptionId, List<Mqtt5Properties> u
*
* @param message message to publish
* @return publish's response
* @throws StatusRuntimeException on errors
* @throws io.grpc.StatusRuntimeException on errors
*/
MqttPublishReply publishMqtt(@NonNull Mqtt5Message message);

Expand All @@ -108,7 +108,7 @@ MqttSubscribeReply subscribeMqtt(Integer subscriptionId, List<Mqtt5Properties> u
*
* @param filters topic filters to unsubscribe
* @return reply to unsubscribe
* @throws StatusRuntimeException on errors
* @throws io.grpc.StatusRuntimeException on errors
*/
default MqttSubscribeReply unsubscribeMqtt(@NonNull String... filters) {
final List<Mqtt5Properties> userProperties = null;
Expand All @@ -121,15 +121,15 @@ default MqttSubscribeReply unsubscribeMqtt(@NonNull String... filters) {
* @param userProperties optional MQTT v5.0 user properties
* @param filters topic filters to unsubscribe
* @return reply to unsubscribe
* @throws StatusRuntimeException on errors
* @throws io.grpc.StatusRuntimeException on errors
*/
MqttSubscribeReply unsubscribeMqtt(List<Mqtt5Properties> userProperties, @NonNull String... filters);

/**
* Close MQTT connection to the broker.
*
* @param reason reason code of disconnection as specified by MQTT v5.0 in DISCONNECT packet
* @throws StatusRuntimeException on errors
* @throws io.grpc.StatusRuntimeException on errors
*/
default void closeMqttConnection(int reason) {
closeMqttConnection(reason, null);
Expand All @@ -140,7 +140,7 @@ default void closeMqttConnection(int reason) {
*
* @param reason reason code of disconnection as specified by MQTT v5.0 in DISCONNECT packet
* @param userProperties optional MQTT v5.0 user properties
* @throws StatusRuntimeException on errors
* @throws io.grpc.StatusRuntimeException on errors
*/
void closeMqttConnection(int reason, List<Mqtt5Properties> userProperties);
}
8 changes: 4 additions & 4 deletions .../java/com/aws/greengrass/testing/mqtt/client/control/implementation/AgentControlImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ boolean isOnThatAddress(@NonNull String address, int port) {
*
* @param subscribeRequest subscribe request
* @return reply to subscribe
* @throws StatusRuntimeException on errors
* @throws io.grpc.StatusRuntimeException on errors
*/
MqttSubscribeReply subscribeMqtt(@NonNull MqttSubscribeRequest subscribeRequest) {
int connectionId = subscribeRequest.getConnectionId().getConnectionId();
Expand All @@ -238,7 +238,7 @@ MqttSubscribeReply subscribeMqtt(@NonNull MqttSubscribeRequest subscribeRequest)
*
* @param unsubscribeRequest unsubscribe request
* @return reply to unsubscribe
* @throws StatusRuntimeException on errors
* @throws io.grpc.StatusRuntimeException on errors
*/
MqttSubscribeReply unsubscribeMqtt(@NonNull MqttUnsubscribeRequest unsubscribeRequest) {
int connectionId = unsubscribeRequest.getConnectionId().getConnectionId();
Expand All @@ -251,7 +251,7 @@ MqttSubscribeReply unsubscribeMqtt(@NonNull MqttUnsubscribeRequest unsubscribeRe
*
* @param publishRequest publish request
* @return reply to publish
* @throws StatusRuntimeException on errors
* @throws io.grpc.StatusRuntimeException on errors
*/
MqttPublishReply publishMqtt(@NonNull MqttPublishRequest publishRequest) {
int connectionId = publishRequest.getConnectionId().getConnectionId();
Expand All @@ -264,7 +264,7 @@ MqttPublishReply publishMqtt(@NonNull MqttPublishRequest publishRequest) {
* Close MQTT connection to the broker.
*
* @param closeRequest parameters of MQTT disconnect
* @throws StatusRuntimeException on errors
* @throws io.grpc.StatusRuntimeException on errors
*/
void closeMqttConnection(@NonNull MqttCloseRequest closeRequest) {
blockingStub.closeMqttConnection(closeRequest);
Expand Down
4 changes: 2 additions & 2 deletions uat/testing-features/src/main/java/com/aws/greengrass/steps/MqttControlSteps.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ public MqttControlSteps(
* Convert boolean string to value.
*
* @param value the string value of boolean
* @return boolean object of value
*/
@SuppressWarnings("PMD.UnnecessaryAnnotationValueElement")
@ParameterType(value = "true|True|TRUE|false|False|FALSE")
Expand All @@ -315,6 +316,7 @@ public Boolean booleanValue(String value) {
* Convert boolean or null string to nullable value.
*
* @param value the string value of boolean or null
* @return boolean object of value or null
*/
@SuppressWarnings("PMD.UnnecessaryAnnotationValueElement")
@ParameterType(value = "true|True|TRUE|false|False|FALSE|null|NULL")
Expand Down Expand Up @@ -1152,7 +1154,6 @@ private void receive(String message, String clientDeviceId, String topicString,
* @param clientDeviceId the user defined client device id
* @param value the duration of time to wait for message
* @param unit the time unit to wait
* @throws TimeoutException when matched message was not received in specified duration of time
* @throws RuntimeException on internal errors
* @throws InterruptedException then thread has been interrupted
*/
Expand All @@ -1167,7 +1168,6 @@ public void checkIsNotDisconnect(String clientDeviceId, int value, String unit)
* @param clientDeviceId the user defined client device id
* @param value the duration of time to wait for message
* @param unit the time unit to wait
* @throws TimeoutException when matched message was not received in specified duration of time
* @throws RuntimeException on internal errors
* @throws InterruptedException then thread has been interrupted
*/
Expand Down
Loading
Loading