feat(uat): implement scenario outline GGMQ-1-T27 #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 130278a |
MikeDombo
reviewed
Jul 27, 2023
| Then I retrieve the certificate of broker "default_broker" and store as "BROKER_CERTIFICATE_BEFORE_DISCONNECT" | ||
|
|
||
| When I set device mqtt connectivity to offline | ||
| And the greengrass log on the device contains the line "com.aws.greengrass.mqttclient.AwsIotMqtt5Client: Failed to connect to AWS IoT Core" at least 3 times within 2 minutes |
There was a problem hiding this comment.
why do you want this 3 times? Why isn't 1 enough?
There was a problem hiding this comment.
At first time 1 is enough. Usually Nucleus makes 3 attempts in the short period of time like:
2023-07-25T20:43:30.342Z [ERROR] (Thread-10) com.aws.greengrass.mqttclient.AwsIotMqtt5Client: Failed to connect to AWS IoT Core. {clientId=gg-5e37c73c40370bb47008-ggc-thing, error=socket operation timed out.}
2023-07-25T20:43:34.858Z [ERROR] (Thread-10) com.aws.greengrass.mqttclient.AwsIotMqtt5Client: Failed to connect to AWS IoT Core. {clientId=gg-5e37c73c40370bb47008-ggc-thing, error=socket operation timed out.}
2023-07-25T20:43:37.958Z [ERROR] (Thread-10) com.aws.greengrass.mqttclient.AwsIotMqtt5Client: Failed to connect to AWS IoT Core. {clientId=gg-5e37c73c40370bb47008-ggc-thing, error=socket operation timed out.}
There was a problem hiding this comment.
So if you only need 1, why does this step require 3?
There was a problem hiding this comment.
I assumed Nucleus made series of attempts before falling to disconnected state.
There was a problem hiding this comment.
There was a problem hiding this comment.
onDisconnection() log another message - "Connection interrupted".
Message "Failed to connect to AWS IoT Core" we are waiting for logged from onConnectionFailure() which called 3 times after onDisconnection() .
But "Connection interrupted" is appeared already in log file.
There was a problem hiding this comment.
Yes, "Connection interrupted" means that the device was disconnected. If you see this, and there is no "Connection resumed" then it is offline.
There was a problem hiding this comment.
At the moment has no steps to check log file miss some string.
MikeDombo
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Implement GGMQ scenario based on GGAD-1-T27
Description of changes:
Why is this change necessary:
Implement replacement of GGAD-1-T27 scenario outline
How was this change tested:
Scenarios have been run on Linux for 4 clients (later reduced to 1) and Windows (one client) for both MQTT v3 and v5.
Test results:
Linux:
Windows:
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.