[DRAFT] chore(storage-browser): replace history with location #5984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebpollman
commented
Oct 31, 2024
Comment on lines
+46
to
+49
| /** | ||
| * current `location` subpath within a `location` | ||
| */ | ||
| path: string | undefined; |
There was a problem hiding this comment.
path updates on location change events with a location:
// <bucket>/<prefix>/<path>
// initial: 'my-bucket/my-prefix/'
const path = undefined;
// enter nested location: 'my-bucket/my-prefix/a-folder/'
const path = 'a-folder/';
// enter deeply nested folder: 'my-bucket/my-prefix/a-folder/extra-nested/further-nexted/'
const path = 'a-folder/extra-nested/further-nested/';
// navigate up two levels: 'my-bucket/my-prefix/a-folder/'
const path = 'a-folder/;
Comment on lines
+41
to
+44
| /** | ||
| * current `location` metadata | ||
| */ | ||
| location: LocationData | undefined; |
There was a problem hiding this comment.
location stays stable between navigation events within a location, e.g. entering/exiting a nested folder
cshfang
reviewed
Oct 31, 2024
Comment on lines
+1
to
+7
| export { | ||
| HistoryActionType, | ||
| HistoryProvider, | ||
| HistoryState, | ||
| HistoryProviderProps, | ||
| useHistory, | ||
| } from './context'; |
There was a problem hiding this comment.
"Cmd + c" -> "Cmd + v" problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.