-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ReadMe Language based on ACP-77 Updates #630
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meaghan FitzGerald <[email protected]>
meaghanfitzgerald
requested review from
iansuvak,
geoff-vball,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
October 29, 2024 19:24
meaghanfitzgerald
changed the title
[WIP] Update ReadMe Language based on ACP-77 Updates
Update ReadMe Language based on ACP-77 Updates
Oct 29, 2024
cam-schultz
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update the type definitions in the Solidity contracts
EDIT: Put this together here: #632
Co-authored-by: cam-schultz <[email protected]> Signed-off-by: Meaghan FitzGerald <[email protected]>
Signed-off-by: Meaghan FitzGerald <[email protected]>
Signed-off-by: Meaghan FitzGerald <[email protected]>
Signed-off-by: Meaghan FitzGerald <[email protected]>
cam-schultz
approved these changes
Oct 30, 2024
update to latest names in acp-77 spec
bernard-avalabs
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a few minor suggestions.
Co-authored-by: bernard-avalabs <[email protected]> Signed-off-by: Meaghan FitzGerald <[email protected]>
geoff-vball
approved these changes
Oct 31, 2024
iansuvak
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Updates the explanatory language of the validator manager readme by correcting broken links and transaction type naming that changes with the distinction between Subnets and L1s.
How this works
contracts/validator-manager/README.md
andcontracts/validator-manager/MessageSpec.md
based on most recent version of ACP-77.