Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReadMe Language based on ACP-77 Updates #630

Merged
merged 17 commits into from
Oct 31, 2024

Conversation

meaghanfitzgerald
Copy link
Contributor

@meaghanfitzgerald meaghanfitzgerald commented Oct 29, 2024

Why this should be merged

Updates the explanatory language of the validator manager readme by correcting broken links and transaction type naming that changes with the distinction between Subnets and L1s.

How this works

  • Updated contracts/validator-manager/README.md and contracts/validator-manager/MessageSpec.md based on most recent version of ACP-77.
  • Removes unnecessary capitalization of "validator" and "delegator" except when used to refer to the Validator Manager contract specifically.

@meaghanfitzgerald meaghanfitzgerald changed the title [WIP] Update ReadMe Language based on ACP-77 Updates Update ReadMe Language based on ACP-77 Updates Oct 29, 2024
Copy link
Contributor

@cam-schultz cam-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the type definitions in the Solidity contracts

EDIT: Put this together here: #632

contracts/validator-manager/MessageSpec.md Outdated Show resolved Hide resolved
contracts/validator-manager/MessageSpec.md Outdated Show resolved Hide resolved
contracts/validator-manager/MessageSpec.md Outdated Show resolved Hide resolved
contracts/validator-manager/MessageSpec.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bernard-avalabs bernard-avalabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a few minor suggestions.

contracts/validator-manager/README.md Outdated Show resolved Hide resolved
contracts/validator-manager/README.md Outdated Show resolved Hide resolved
contracts/validator-manager/README.md Outdated Show resolved Hide resolved
Co-authored-by: bernard-avalabs <[email protected]>
Signed-off-by: Meaghan FitzGerald <[email protected]>
@cam-schultz cam-schultz merged commit 7564686 into main Oct 31, 2024
16 checks passed
@cam-schultz cam-schultz deleted the validator-manager-readme branch October 31, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

5 participants