PoA e2e test #497
Merged
PoA e2e test #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 21, 2024 09:47
minghinmatthewlam
added
enhancement
minghinmatthewlam
added this to the Staking Manager MVP - all PRs should target staking-contract branch milestone
minghinmatthewlam
requested review from
iansuvak,
feuGeneA,
geoff-vball,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
added 2 commits
August 21, 2024 10:44
cam-schultz
reviewed
Aug 21, 2024
tests/local/e2e_test.go
Outdated
| @@ -22,7 +25,7 @@ const ( | |||
| upgradabilityLabel = "upgradability" | |||
| utilsLabel = "utils" | |||
| validatorSetSigLabel = "ValidatorSetSig" | |||
| stakingManagerLabel = "StakingManager" | |||
| stakingManagerLabel = "ValidatorManager" | |||
There was a problem hiding this comment.
We can update this var to validatorManagerLabel
Co-authored-by: cam-schultz <[email protected]> Signed-off-by: minghinmatthewlam <[email protected]>
Co-authored-by: cam-schultz <[email protected]> Signed-off-by: minghinmatthewlam <[email protected]>
Co-authored-by: cam-schultz <[email protected]> Signed-off-by: minghinmatthewlam <[email protected]>
cam-schultz
approved these changes
Aug 21, 2024
added 2 commits
August 21, 2024 14:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adding a basic PoA e2e test flow
How this works
Deploys a PoAValidatorManager with an owner
Makes sure only owner can call
Initiates and completes a validator registration
Initiates and completes a validator end
Refactors test flows to match contract structure