ACP-77: Add subnetIDNodeID struct #3499
Open
+103
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
reviewed
Oct 25, 2024
| fz := fuzzer.NewFuzzer(data) | ||
| fz.Fill(&v0, &v1) | ||
|
|
||
| if v0.subnetID == v1.subnetID { |
There was a problem hiding this comment.
is this return statement and if condition essential?
There was a problem hiding this comment.
If the subnetIDs are equal, then the comparison depends on the nodeIDs as well.
yacovm
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Factored out of #3388.
How this works
Adds a struct to merge
subnetIDs andnodeIDs together. This struct supports directly marshaling into bytes because it will be used as a key into the database.How this was tested
Need to be documented in RELEASES.md?
No.