-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuous Staking 3 - Restake primary network stakers by default #1494
Open
abi87
wants to merge
142
commits into
stakerTxs_drop_start_time
Choose a base branch
from
continuous_staking_primary_network
base: stakerTxs_drop_start_time
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Continuous Staking 3 - Restake primary network stakers by default #1494
abi87
wants to merge
142
commits into
stakerTxs_drop_start_time
from
continuous_staking_primary_network
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… properly handled
abi87
commented
Aug 17, 2023
|
||
res := int(validatorPeriod) / int(delegatorPeriod) | ||
rem := validatorPeriod % delegatorPeriod | ||
if rem != 0 || (res&(res-1)) != 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
powers of two are such that (res&(res-1)) == 0
Signed off-by: Alberto Benegiamo <[email protected]>
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Simplify staking operations, specifically for primary network validators and delegators which intend to stake for long time
How this works
Post Continuous Staking fork activation:
5.Added stopStakerTx to explicitly stop staking. Duly handled delegators/subnet validators termination when their validator is requested to stop.
Open Issues
state.rewardUTXOsCache
does not seems currently fit to hold multiple rewardUTXOs accrued across different reward cycle. Fix itHow this was tested
TODOs
Add e2e tests with ginkgo