Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): remove TODO comments and unnecessary copies of source code #5253

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Sep 18, 2024

Description

Resolves autowarefoundation/autoware.universe#8695

This PR removes TODO comments and unnecessary copies of the source code since the issue autowarefoundation/autoware.universe#8695 has been resolved.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk self-assigned this Sep 18, 2024
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Sep 18, 2024
@youtalk youtalk marked this pull request as ready for review September 18, 2024 05:28
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk merged commit e7ad303 into main Sep 18, 2024
32 checks passed
@youtalk youtalk deleted the resolve-issues-8695 branch September 18, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

common packages are not functioning as a true "common"
2 participants