feat: attach git diff in the PR description
#323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junya Sasaki <[email protected]>
Signed-off-by: Junya Sasaki <[email protected]>
youtalk
reviewed
Oct 8, 2024
create-prs-to-update-vcs-repositories/create_prs_to_update_vcs_repositories.py
Outdated
Show resolved
Hide resolved
…_repositories.py Signed-off-by: Junya Sasaki <[email protected]> Co-authored-by: Yutaka Kondo <[email protected]>
xmfcx
reviewed
Oct 8, 2024
create-prs-to-update-vcs-repositories/create_prs_to_update_vcs_repositories.py
Show resolved
Hide resolved
…_repositories.py Signed-off-by: Junya Sasaki <[email protected]> Co-authored-by: M. Fatih Cırıt <[email protected]>
|
Thank you for your proposals! Now let me do tests again with the fixed one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes so the version update PR contains the
git diffof the target repository.Currently the version update PR contains poor information in its description as this and this makes the review difficult.
Related links
Discussion for feature improvement
Tests performed
After the PR author finishes their tests, this will be updated.I verified that a PR is created as this. The PR contains the
git diffso I believe this is enough as tests.Notes for reviewers
Currently, the version update PR does not contain
git diffand the reviewer needs to go to the target repository by themselves. This PR reduces such the additional task.Interface changes
No interface changes.
ROS Topic Changes
No ROS topic changes.
ROS Parameter Changes
No ROS parameter changes.
Effects on system behavior
The version update PR will be containing additional information (
git diff).Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.