Add hack/install-os-deps.sh #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmah42
reviewed
Aug 9, 2024
| - name: Cargo build, lint, test [make test] | ||
| # This should remain the only command we execute as this matches the title of the file. | ||
| # The goal is for this to be easy to find from the GitHub dashboard. | ||
| # Instead of adding more commands here, consider another make target or a new YAML file | ||
| # named with a good name. | ||
| run: make auraed-test | ||
| run: make os-deps auraed-test |
There was a problem hiding this comment.
should auraed-test just depends on os-deps? or on auraed-build which depends on os-deps...
that would make things easier for people getting started I think.
There was a problem hiding this comment.
hrm I'm not sure what the best ux is. Most likely os-deps needs to get added to one or more of the super targets, but not sure which. Thoughts?
There was a problem hiding this comment.
leave this as it is (and yes please update the other workflows) and I'll see what I can do.
bpmooch
force-pushed
the
build-deps-script
branch
from
75801c7
to
cdd90b8
Compare
|
if checks pass, I might update 002 and 003 gh workflows with the same refactor I did to 001 |
dmah42
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a script to install os dependencies for building aurae and used it in a github workflow to test it out