Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added if for iframe issue in player #728

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NexisSis
Copy link

@NexisSis NexisSis commented Jul 17, 2020

Hey everyone,
i'm using ethercalc in iframe (this is the only solution for my project), and i can't do export table, because JavaScript can't get window.parent.location.pathname from iframe.
I created a solutions, that check if this window is iframe, and if yes we can open file without window.parent.location.pathname.
Also remove unused spaces (my linter :))

@ocdtrekkie
Copy link

It's a little surprising you hit an issue here, the Sandstorm version already works correctly in this regard (EtherCalc is run in an iframe in Sandstorm), unless there's already some sort of fix on the Sandstorm branch specifically.

@NexisSis
Copy link
Author

NexisSis commented Jul 20, 2020

It's a little surprising you hit an issue here, the Sandstorm version already works correctly in this regard (EtherCalc is run in an iframe in Sandstorm), unless there's already some sort of fix on the Sandstorm branch specifically.

rly?. Check last error :)
Cross

@ocdtrekkie
Copy link

Interesting... And you get this when you select the save icon, and select an export format?

I did test before I had responded! Though I do use Firefox, so I am not sure if it's perhaps a browser-specific change that's causing the problem.
image

@ocdtrekkie
Copy link

Of course, if it's a problem from your browser, it is probably a problem for many other users too, and so a fix will be important... I was just surprised you hit an issue here. :)

@NexisSis
Copy link
Author

Of course, if it's a problem from your browser, it is probably a problem for many other users too, and so a fix will be important... I was just surprised you hit an issue here. :)

i'm using latest google chrome, so i think it's a big problem for much users

@eddyparkinson
Copy link
Collaborator

works fine on Chrome for me. The /appeditor options used iframes

http://sheet.cellmaster.com.au/example_button/appeditor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants