Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve docker-compose #716

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gnouts
Copy link

@gnouts gnouts commented Apr 18, 2020

Fix : #715

@eddyparkinson
Copy link
Collaborator

eddyparkinson commented Apr 21, 2020

Thanks for the fix.

Has this been tested. Maybe a new install to check everything still installs?
Redis is optional, it should run with or without redis.
Please post some details of testing done. Thanks.

@gnouts
Copy link
Author

gnouts commented Apr 21, 2020

Yes I've tested it on my local computer.

Indeed it could be good to choose to use Redis or not. I didn't want to go to this complexity. I just wanted to fix some unwanted behaviour that could break server, not improving things. ^^
But while I talk about it, I don't think mounting redis db as a volume is needed at all. But maybe it used to be needed for something ?

You can test it easily by running docker-compose up from the repo directory (supposing you have docker+docker-compose)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-compose should not mount /var/lib/redis
2 participants