Skip to content

Commit

Permalink
Make "enable_batching" parameter viewable, optional, default false
Browse files Browse the repository at this point in the history
There are tradeoffs associated with Segment event batching - there is no
realtime feedback if the request was invalid, for example - so we should
make it opt-in and controllable by the user.
  • Loading branch information
Nick Campbell committed May 28, 2024
1 parent fe3c78b commit 333f3e3
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ import { Settings } from './generated-types'
export const commonFields: ActionDefinition<Settings>['fields'] = {
enable_batching: {
label: 'Send data to Attio in batches',
description: 'Send data to Attio in batches for much better performance.',
description:
'Send batches of events to Attio, for improved performance, however invalid events are silently dropped.',
type: 'boolean',
required: false,
unsafe_hidden: true,
default: true
default: false
},

batch_size: {
Expand Down

0 comments on commit 333f3e3

Please sign in to comment.