This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a PR yet, but rather a first step to ask:
Description of the Change
This features adds the site avatar below its cursor. To do so, it uses
TextEditor.decorateMarkerLayer
with typeoverlay
.The fact that it's added into the existing markerLayersBySite system has the benefit that the suppression on site disconnection is already handled.
Alternate Designs
Other avatars are displayed in React elements, but it was more complicated to follow the cursor. I believe it perfectly fits as a use case of overlay decoration.
Benefits
The participants follow more easily what others do.
Possible Drawbacks
I saw the avatars are drawn above the bottom bar.
Verification Process
Only manually tested for now.