Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Export PathFilter #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vergenzt
Copy link

@vergenzt vergenzt commented May 1, 2020

Hi! The README mentions that PathFilter "is available", but it didn't appear to be exported. 🙂 PathFilter would be a very useful utility to have access to in my particular use case.

Hi! The README mentions that PathFilter is available as an export, but it didn't appear to be exported. 🙂 It also would be very useful in my particular case.
@vergenzt
Copy link
Author

vergenzt commented May 1, 2020

🤔 Build failure doesn't appear to be related to my change.

Also I just realized I can already import PathFilter via require('scandal/src/path-filter') -- so this isn't a blocker for me, just a nice-to-have. (Would rather not depend on something that's not explicitly exported by the package. 😬)

Edit: require('scandal/src/path-filter') wasn't working, which led me to realize I have to require('scandal/lib/path-filter) (the compiled JS module) for the unexported require to work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant