Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORC-3547 Support updating workflow template spec #42

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ORC-3547 Support updating workflow template spec #42

wants to merge 1 commit into from
+1,560 −3,061

Conversation

louisnow
Copy link
Contributor

@louisnow louisnow commented Jul 4, 2022 •
edited
Loading

Details in ticket https://linear.app/atlanproduct/issue/ORC-3547

This allows us to have things like custom node affinity, PVC claims per workflow to exist and be up to date.

Working

  • When a cluster workflow is installed, fetch it's workflow templates
  • Copy the cluster workflow template's spec fields such as PVC etc and add it to workflow template.
  • Delete the templates spec as we don't want the kubernetes patch request going out to modify the template which contains the workflow arguments.

@linear
Copy link

linear bot commented Jul 4, 2022

ORC-3547

@louisnow louisnow force-pushed the louis/workflow-template-spec branch from e349845 to e4672ba Compare July 4, 2022 21:14
@louisnow louisnow requested a review from firecast July 5, 2022 05:16
@louisnow louisnow marked this pull request as draft July 5, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firecast firecast Awaiting requested review from firecast

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@louisnow