Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support devices : add touchstart touchend touchmove touchcancel events #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Ismailmehri
Copy link

No description provided.

@asvd
Copy link
Owner

asvd commented Nov 3, 2015

thanks for your contribution!

before merging, a couple of questions/remarks:

  1. What is the need of special supporting for those events? I checked dragscroll on chrome / ipad, and there were no problem, since the touch-scrolling is performed there natively, without involving dargscroll.js.
  2. On which device / browser do you test these events?
  3. For the sake of minification, similar listener functions for all three "scroll-end" events can probably be declared once and reused:

Ismailmehri@e8bcb08#diff-f3eeac0eb8612bcf28b6c2f0c4200bbbR75

But maybe I can do that myself after merging.

@Ismailmehri
Copy link
Author

hello,
1/2 : I tested it on IOS and Android devices, but it does not work.
example 1 : https://jsfiddle.net/fhx47rc2/3/
example 2 : https://jsfiddle.net/fhx47rc2/4/

@asvd
Copy link
Owner

asvd commented Nov 4, 2015

Reproduced. I'll have to investigate on this, since I'm wondering why the demopage works on tablets without any special tuning:

http://asvd.github.io/dragscroll/

@MartinMalinda
Copy link

This should work on mobile with overflow:auto. With overflow hidden theres no scroll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants