Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix continuous integration #29

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix continuous integration #29

merged 1 commit into from
Sep 10, 2024

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented Sep 9, 2024

This tests against astropy stable by default instead of astropy dev - the latter is now opt-in.

This should fix the CI but does not solve #21

Blocks:

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for now but it is going to break again when astropy v7.0 is released.

@pllim pllim merged commit 818226c into astropy:main Sep 10, 2024
4 checks passed
@astrofrog
Copy link
Member Author

Why will it break again?

@pllim
Copy link
Member

pllim commented Sep 10, 2024

Astropy v7.0 does not support py310.

@astrofrog
Copy link
Member Author

It shouldn't matter as the py310 job will just pick the latest compatible release? (Because of requires_python)

@pllim
Copy link
Member

pllim commented Sep 10, 2024

Ah, yes. OK, so it will work until astropy-dev drops Python 3.12. I see.

@pllim
Copy link
Member

pllim commented Sep 11, 2024

I triggered a new update and it passed. Thanks again!

https://github.com/astropy/astropy-iers-data/actions/runs/10817248138/job/30010439947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants