Run integration tests in CI #266
Merged
+357
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajkoti
force-pushed
the
integration-tests
branch
from
b7af053
to
1c994d2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
=======================================
Coverage 92.53% 92.53%
=======================================
Files 8 8
Lines 630 630
=======================================
Hits 583 583
Misses 47 47 ☔ View full report in Codecov by Sentry. |
pankajkoti
commented
Oct 21, 2024
pankajkoti
force-pushed
the
integration-tests
branch
from
ce1232b
to
a539b97
Compare
tatiana
reviewed
Oct 21, 2024
tatiana
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
This looks great, @pankajkoti , really happy we'll have these integration tests to give us more confidence when making changes and accepting contributions to DAG factory.
I left a minor feedback inline.
pankajastro
reviewed
Oct 21, 2024
pankajastro
approved these changes
Oct 21, 2024
pankajkoti
force-pushed
the
integration-tests
branch
2 times, most recently
from
6da9307
to
f17e83d
Compare
pankajkoti
force-pushed
the
integration-tests
branch
from
f17e83d
to
f76d9bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #198
closes: #206