Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase project quality #206

Closed
5 tasks done
Tracked by #217
pankajkoti opened this issue Jul 24, 2024 · 2 comments · Fixed by #266
Closed
5 tasks done
Tracked by #217

Increase project quality #206

pankajkoti opened this issue Jul 24, 2024 · 2 comments · Fixed by #266
Assignees
Labels

Comments

@pankajkoti
Copy link
Contributor

pankajkoti commented Jul 24, 2024

@matveykortsev
Copy link
Contributor

Guys add please support for on_failure_callback in this way:

from airflow.providers.slack.notifications.slack import send_slack_notification
'on_failure_callback': [
        send_slack_notification(
            slack_conn_id='slack',
            text="""
                :red_circle: Task Failed. 
                *Task*: {{ ti.task_id }}  
                *Dag*: {{ ti.dag_id }} 
                *Execution Time*: {{ ti.execution_date }}  
                *Log Url*: {{ ti.log_url }} 
                """,
            channel="analytics-alerts",
            username="Airflow",
        )
    ],

Now its only possible without params and only through absolute path for .py file.

@pankajastro
Copy link
Contributor

pankajastro commented Jul 24, 2024

Thank you, @matveykortsev, indeed, this feature would be valuable. I've created a high-level task #200 to compare the missing issues like this.

@phanikumv phanikumv removed the epic label Sep 6, 2024
@pankajkoti pankajkoti self-assigned this Oct 7, 2024
tatiana pushed a commit that referenced this issue Oct 15, 2024
The make docker-run currently appears to be broken.
The changes in this PR attempt to resolve the errors by installing Airflow
with its constraints.

related: #206
pankajkoti added a commit that referenced this issue Oct 16, 2024
Fix the failed Static Check job here that were observed in #218.
Since the PR was created from a fork, I could not push changes to it
before merging.

related: #206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants