Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useUrlState hook for React-router #10

Merged
merged 6 commits into from
Sep 30, 2024
Merged

useUrlState hook for React-router #10

merged 6 commits into from
Sep 30, 2024

Conversation

asmyshlyaev177
Copy link
Owner

PR title

Proposed Changes

Breaking Changes

Remove symbols for most of types and keep only props as object for useUrlState

BREAKING CHANGE: 1. `useUrlState` for Next.js now accept only object, eg. `useUrlState({
defaultState: {}})`
 2. urls encoded with versions prior to v2.3.0 could stop working
Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for state-in-url failed.

Name Link
🔨 Latest commit 40209f6
🔍 Latest deploy log https://app.netlify.com/sites/state-in-url/deploys/66fab81172c3b30008f7e5b2

Copy link

codacy-production bot commented Sep 30, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+9.98% (target: -1.00%) 93.75%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6fab20c) 217 193 88.94%
Head commit (40209f6) 185 (-32) 183 (-10) 98.92% (+9.98%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#10) 16 15 93.75%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@asmyshlyaev177 asmyshlyaev177 merged commit 535e0bf into main Sep 30, 2024
10 of 15 checks passed
@asmyshlyaev177 asmyshlyaev177 deleted the react-router branch September 30, 2024 15:06
asmyshlyaev177 pushed a commit that referenced this pull request Oct 9, 2024
`useUrlState` hook for React-router
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant