-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.14.0 #519
base: master
Are you sure you want to change the base?
Release 0.14.0 #519
Conversation
This is the thing I always wanted & never got the time to actually do. Wow. |
Wow!!! This is fantastic! Wanna test this as soon as possible!! |
For everybody willing to test this, you can easily install this version from my repository: https://github.com/caphm/kodi-repo/raw/master/repository.kodi-repo-caphm/repository.kodi-repo-caphm-1.0.0.zip Please make sure to do a backup of at least your library exports folders. This version uses some new storage formats, for which I have not yet fully implemented migration logic (still to come though). |
OHH this is awesome, I will test om my work machine. Thanks caphm! |
Wow a really big part of work! Currently now testing on my RPI3b+ - sometimes i noticed timeouts from addon signals - seems to be caused by the downloads of artwork on first enter the tv show list etc which needs more time than the failsave allows before the warning... |
It seems library export is broken - my destination is located on a nfs which results in a read only fs fail (but it's rw and working on another mashine with plugin 13.x) - possible a rework with the xbmcvfs handling ? |
@hawkeyexp Artwork downloads are handled by Kodi after the video listing has been built. This must be due to raw API operation. Timeouts can be caused by two things:
What I have noticed is, that if there are many addons running alongside, performance may sometimes be severely impacted. This isn't much of an issue on my hardware (Core i5), but can certainly push low powered hardware to its knees. |
@hawkeyexp library export uses native os.open and not xbmcvfs. I'll rework that. |
@caphm - ok perfect - i had a look inside but you can do it more easy cause the big reworks needs time to step in again :-) PS: a solve of the merge conflicts would be great to prevent from manual fixes on merge :-) |
The conflicting changes currently in master can be overwritten when merging this PR. The features added by @liberty-developer have been incorporated into this PR. |
Error Playback Input for argument "input" for "Encrypt" must be a string or a byte array. |
Should be fixed with latest commit. Updated version is also in the repo. Thanks for catching that! Unfortunately I cannot test on Android :( |
Good catch, thanks! I added a try/catch. Unfortunately I don't know which exceptions xbmcvfs specifically raises, so everything will need to go into ugly broad excepts :( |
Are you sure you're using the 0.14.0 version? This fix should not apply here, because that particular snippet of code (or anything comparable) is no longer used anywhere within the codebase. |
Profiles that are marked as a "child" seems to be broken, I only seem to get Genre, Recommendations All TV shows, All Movies, Search and Exported, all menu items however are then empty, i have 3 other profiles not marked as child and they appear correctly |
As reported in the thread on kodi official forums, i get this error on Nvidia Shield when trying to play any video. "B2a_base64() argument 1 must be string or buffer not dict." Debug log - https://paste.kodi.tv/iqayayoleg.kodi |
Yes, i'm using 0.14.0~beta4 now, and thanks for fixing the 40 episodes limit, it worked just great, the fix i have posted i used it before with 0.13.15 not 0.14.0. https://github.com/caphm/plugin.video.netflix/tree/release/0.14.0 This is the error message which i get when i search for the word "last" I'm using windows 10 and this release from Kodi. KodiSetup-20181102-d0a7c358-master-x86 Kodi log |
I'm getting a "invalidpatherror: no root path to handler extrafanart" error message on my Nvidia Shield, i can not replicate this on my Windows Laptop though, This happens pretty much as soon as I select a profile and navigate to a menu. Extract from Log:
full log from Nvidia Shield also attached: |
Never mind, the search problem fixed in 0.14.0~beta5, thanks for your great work. |
Im getting this to |
At least partially confirmed. Which lists are displayed depends on what returns from the API. If there are no lists returned, the items show up empty. I have had the same issue myself, another user that reported a different (now fixed) issue with kids profiles did receive somelists to display from the API. I'm not sure why Netflix does this... it happened once on a normal profile as well, but I haven't been able to reproduce. In any case, I'll keep this on the to do list for the future, but Kids profiles won't be a focus for this release.
Fixed in beta6
There was another (new) issue with the search term "last", which I encountered and fixed in beta5. Thanks for the report though.
I don't know which addon is generating these stupid extrafanart invocations, but they are now being ignored in beta6 ;) This should be fixed. |
Can't set the old string to widgets. Before I used "plugin://plugin.video.netflix/?action=video_list&type=queue" to get My List as widgets. Edit: Already found a solution to widgets: The string to widgets is now: "plugin://plugin.video.netflix/directory/video_list/queue/" And remove an item from My List in the Netflix Website don't remove the item from kodi library, it work only if we remove the item inside the addon. It would be great if the addon identificates if an item are on list or not, because if some tv show/movie it removed from Netflix, it will be removed from kodi too! Tv shows do not exported with seasons folders. All eps are exported inside a only one folder with the the show name without release year, this can causes wrong identification of the tv show from kodi. Others things that I tested works fine!!! |
I think a fix for this just got a pull request |
Modified patch for @CastagnaIT's fork: --- a/resources/lib/services/nfsession/nfsession.py 2019-03-08 18:31:45.531974969 +0100
+++ b/resources/lib/services/nfsession/nfsession.py 2019-03-08 18:32:41.446971876 +0100
@@ -314,9 +314,11 @@
'Accept': 'application/json, text/javascript, */*'}
params = {
'model': self.session_data['user_data']['gpsModel']}
- data = json.dumps({
- 'paths': paths,
- 'authURL': self.auth_url})
+ data = ""
+ for path in paths:
+ data = data + 'path=' + json.dumps(path) + '&'
+
+ data = data + 'authURL=' + self.auth_url
return self._post(
component='shakti',
req_type='api', |
Tried that patch, beta is still pretty much broken. Videos won't even play. After cleaning my data directory, now I can't even login! |
If it's not failing from login, it's failing from AddonSignals
|
The patch to fix the login is also broken when you enable IPC over HTTP, to workaround the AddonSignals timeout.
|
i haven't tried adding a new show. Perhaps there is an unrelated issue here? |
So I read the wrong commit and applied the wrong patch, the login works fine as far as I can tell, but video playback does not work at all. "Unable to create context (due to ContentException)" I tried with both IPC over HTTP enabled and disabled |
Oh, so the problem was I needed beta20, everything works now. |
Beta 22 is the one with the latest patch. Are sure sure its beta 20 thats working. I just installed beta 22 over beta 20 and it started working again. |
Yeah I'm using Beta22 |
Hi, @CastagnaIT I got a issue with the latest master branch. I can play movie and tv show that are already exported to my library. But I cannot browse any folder from the addon it throw me an error everytime. |
Sorry for still being kind of a newb to Github.. where can I find the latest build everybody is testing? Rather than giving me a direct link, can somebody explain how to find it? |
@chewvodka Many thx at this point to CastagnaIT! |
Thanks, hopefully this will help other people too. So, should be we commenting on THAT github then rather than this one? Looks like its still not working. I installed the new version over the existing. It said an updated to Wildvine was needed. Installed that, then the video I picked played. Yay! Then I rebooted. It looks like I can still log in, but every 30 seconds or so I get an error I'm going to try uninstalling it and reinsalling it. That broke it even more. Now I can't even log in. Keeps saying to check credentials. |
Looks like the latest version is working |
Hello there, Cheers from Mexico! |
@jakermx I'm very very sorry good man, and i wish you a good recovery. But i suggest you to delete these photos, this is not a forum, here are accepted discussions only for development purposes, we risk warnings from github... |
@jakermx - Ouch! I had a surgery in November that took my gall bladder out. Then in January I had a mesh put in to resolve a hernia. Recovery is no joke, but you'll get there eventually! Take your time, take it slow, and don't feel like you need to get back into it right away! Hope you feel better soon. :) |
What is the correct way to install those zip files? Thanks! |
Download the zip. Put it on your device. Inside Kodi go to Settings -> Addons -> Install from Zip -> Navigate to and select the Zip you put on the device. This installs it. |
Thanks! Do I have to uninstall older versions first? |
I tried the latest beta and latest nightly build and both don't work. Here is the part of the log file that seems relevant. Any idea?
|
Yes, Uninstall it, Disable Add AutoUpdates, Reboot, Install from ZIP, Not needed but I recommend to restart before first use. I just made a LibreElec clean install and I just had an issue with AddOnSignals, so I enabled IPC and viola!! |
How is the progress on this pull request? |
it is already being updated the regular way just install the new repo this repository has mostly been abandoned. |
Ah, many thanks for the info! |
I have raised this question on kodinerds.net. Caphm is not available at the Moment. Thankfully others have continue the work. But that is Not a reason to have a New fork. In my point of view this repo is still active as we could See last changes by netflix 1,5 monts ago. V13,x is still working fine. We only need a New pull request. But if the repo owner don't want to continue we need to change of course. |
I got that issue today, the models API_BASE_URL its gone, so I modifyed website.py and nfsession.py pointing to the new model element called apiUrl, look at @CastagnaIT issues section for my workaround. |
Please help test this before it gets merged!
For testing purposes, you can install via zip file (download Code of last commit) or directly from my repo: https://github.com/caphm/kodi-repo/raw/master/repository.kodi-repo-caphm/repository.kodi-repo-caphm-1.0.0.zip
(new commits to this PR will be pushed to this repo as new beta versions)
This is a big one: While running down the list of bugs to fix, I have heavily refactored the entire addon (and essentially rewritten most of the code).
The major changes are:
In my experience this is all around faster, better, stronger ;)
Before this is released though, I'd like to have some feedback and ideally a couple of beta testers who really try to break it.
I will add some more changes to this in the future (Up Next integration, more features), but I believe this is ready for prime time.
Finally, here comes the list of bugfixes:
Types of changes
All Submissions:
Changes to Core Features: