Skip to content

Commit

Permalink
ci: Fix golangci-lint installation (uber-go#1424)
Browse files Browse the repository at this point in the history
`golangci-lint run` no longer accepts `--version`,
so the hack we employ to install it using the official action
no longer works.

This replaces the flag with `--help`, and fixes broken CI.

Resolves uber-go#1423

---------

Signed-off-by: junya koyama <[email protected]>
Co-authored-by: Abhinav Gupta <[email protected]>
  • Loading branch information
arukiidou and abhinav authored Apr 2, 2024
1 parent b39f8b6 commit b15585b
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ jobs:
name: Install golangci-lint
with:
version: latest
args: --version # make lint will run the linter
# Hack: Use the official action to download, but not run.
# make lint below will handle actually running the linter.
args: --help

- run: make lint
name: Lint
Expand Down

0 comments on commit b15585b

Please sign in to comment.