feat(ONYX-1294): add priceListed field to PartnerOfferToCollectorType #6154
+59
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I wonder why we don't use the list price from the artwork 🤔 But you're right, it makes sense to add it to PartnerOfferToCollector as well for consistency.
Could you add some tests for the new field here please (this seems to be the only place that tests PartnerOfferToCollector offers) 🙏
olerichter00
force-pushed
the
dariakoko/add-PriceListed-to-PartnerOfferToCollectorType
branch
from
2e660ed
to
3d36b09
Compare
olerichter00
approved these changes
Oct 23, 2024
MrSltun
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add priceListed field to PartnerOfferToCollectorType
According to ONYX-1294 we need to display priceListed on the partner offer sale details
Instead of getting this information from the artwork, let's expose another field in PartnerOfferToCollectorType in order to stay consistent