-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isProfileComplete): remove other_relevant_positions from isProfileComplete #5824
base: main
Are you sure you want to change the base?
feat(isProfileComplete): remove other_relevant_positions from isProfileComplete #5824
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
!!location?.display && | ||
!!profession && | ||
!!other_relevant_positions, | ||
resolve: ({ icon, name, location, profession }) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Why don't we add the isVerified
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's see what the folks think about the discussion here
Related to DIA-561
Removes the field
other_relevant_positions
fromisProfileComplete
. We no longer require this field as a necessary one for the completeness of the profile.