Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radxa Rock-3a - edge - use mainline uboot #7401

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Radxa Rock-3a - edge - use mainline uboot #7401

merged 2 commits into from
Oct 23, 2024
+22 −0

Conversation

mr-toolcraft
Copy link
Contributor

@mr-toolcraft mr-toolcraft commented Oct 23, 2024 •
edited
Loading

Description

  • switches bleeding edge u-boot to @Kwiboo mainline 2024.10 branch tag
  • get rid of separate boot partition since
    • not needed for modern u-boot
    • fixes armbian-install failing with separate boot partition present

GitHub issue reference:
Jira reference number [AR-9999]

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related like kernel, U-Boot, ... labels Oct 23, 2024
@amazingfate
Copy link
Contributor

Have you tried mainline u-boot?

@Kwiboo
Copy link
Contributor

Kwiboo commented Oct 23, 2024

Have you tried mainline u-boot?

I also suggest you use plain mainline v2024.10, all important patches for rk356x are already included in v2024.10.

@mr-toolcraft
Copy link
Contributor Author

Adjusted and retested. Works as expected.
https://paste.armbian.com/erovehisuk

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 11 Milestone: Fourth quarter release labels Oct 23, 2024
@EvilOlaf EvilOlaf merged commit b0a0a0c into armbian:main Oct 23, 2024
13 checks passed
@mr-toolcraft mr-toolcraft deleted the patch-1 branch October 24, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amazingfate amazingfate amazingfate approved these changes

@catalinii catalinii Awaiting requested review from catalinii catalinii is a code owner

Assignees
No one assigned
Labels
11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mr-toolcraft @amazingfate @Kwiboo @EvilOlaf @igorpecovnik