Add badger implementations of repos #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisinger
approved these changes
Nov 30, 2023
| handler func(round *domain.Round) | ||
| } | ||
|
|
||
| func NewRoundEventRepository(config ...interface{}) (dbtypes.EventStore, error) { |
There was a problem hiding this comment.
any reason to do not type config ?
There was a problem hiding this comment.
because different impls can require different config params.
This way, every impl makes sure that the passed args are exactly those required, instead of having a predefined config that includes all params for the different impls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a badger implementation of the repositories useful for testing purposes but also as an initial persistency layer.
This also adds some changes to the domain layer, required after writing their consumers:
PaymentsClaimedevent for sake of simplicity since it wasn't used by the app layerThis adds logic to the application layer meant to keep the projection store up-to-date with the event store: whenever an event is persisted, the aggregate (round/vtxo) resulting from replaying all events is saved to the proper projection store.
Please @louisinger review.