Pin numpy to 1.21.2
#257
Draft
Pin numpy to 1.21.2
#257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,7 +26,7 @@ def __init__(self, root_dir: str) -> None: | |||
| self.CAMERA_LIST = CAMERA_LIST | |||
| self._log_list: Optional[List[str]] = None | |||
| self._image_list: Optional[Dict[str, Dict[str, List[str]]]] = None | |||
| self._image_list_sync: Optional[Dict[str, Dict[str, List[np.ndarray]]]] = None | |||
| self._image_list_sync: Optional[Dict[str, Dict[str, List[NDArray[np.float64]]]]] = None | |||
There was a problem hiding this comment.
Hi Anna, the image timestamps should be in nanoseconds (integers), so likely we need to cast to np.int32 or np.int64 somewhere beforehand
| @@ -77,7 +77,7 @@ def seq_df(self) -> pd.DataFrame: | |||
| return _read_csv(self.current_seq) | |||
|
|
|||
| @property | |||
| def agent_traj(self) -> np.ndarray: | |||
| def agent_traj(self) -> Any: | |||
There was a problem hiding this comment.
maybe we can cast the return arg to np.array() since, np.column_stack() should hopefully only return an array
johnwlambert
reviewed
Oct 5, 2021
| @@ -117,7 +118,7 @@ def evaluate(self) -> pd.DataFrame: | |||
| gt_fpaths = list(self.gt_root_fpath.glob("*/per_sweep_annotations_amodal/*.json")) | |||
|
|
|||
| assert len(dt_fpaths) == len(gt_fpaths) | |||
| data: DefaultDict[str, List[np.ndarray]] = defaultdict(list) | |||
| data: DefaultDict[str, List[NDArray[np.float64]]] = defaultdict(list) | |||
There was a problem hiding this comment.
Hi @ahuller3, thanks for your work on this.
@benjaminrwilson and I were reviewing this today, and we were thinking it might be easier for readability to do something like
if we create something like argoverse/typing/numpy.py
NDArrayFloat = Union[NDArray[np.float32], NDArray[np.float64]]What are your thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft. Does not need review currently. Will be resolved after
disparity_interpolationrefactor.