added test cases for resource_tracking

Signed-off-by: B Rahul <[email protected]>

util/argo/resource_tracking.go

@@ -82,12 +82,12 @@ func (rt *resourceTracking) getAppInstanceValue(un *unstructured.Unstructured, i
  return value
 }
 
-func (rt *resourceTracking) getAppInstanceIdValue(un *unstructured.Unstructured) *string {
- appInstanceIdValue, err := argokube.GetAppInstanceAnnotation(un, common.AnnotationKeyAppInstanceID)
- if err != nil {
- return nil
- }
- return &appInstanceIdValue
+func (rt *resourceTracking) getAppInstanceIdValue(un *unstructured.Unstructured) string {
+ appInstanceIdValue, err := argokube.GetAppInstanceAnnotation(un, common.AnnotationKeyAppInstanceID)
+ if err != nil {
+ return ""
+ }
+ return appInstanceIdValue
 }
 
 // GetAppName retrieve application name base on tracking method
@@ -133,11 +133,7 @@ func (rt *resourceTracking) GetAppInstance(un *unstructured.Unstructured, key st
 
 // GetAppInstanceID retrieve instance ID of the resource.
 func (rt *resourceTracking) GetAppInstanceID(un *unstructured.Unstructured) string {
- appInstanceIdValue := rt.getAppInstanceIdValue(un)
- if appInstanceIdValue == nil {
- return ""
- }
- return *appInstanceIdValue
+ return rt.getAppInstanceIdValue(un)
 }
 
 // UnstructuredToAppInstanceValue will build the AppInstanceValue based

util/argo/resource_tracking_test.go

@@ -146,6 +146,10 @@ func TestSetAppInstanceIdAnnotation(t *testing.T) {
 
  value := resourceTracking.GetAppInstanceID(&obj)
  assert.Equal(t, "argocd.com", value)
+
+ err = resourceTracking.SetAppInstanceID(&obj, "")
+ require.Error(t, err)
+ assert.Contains(t, err.Error(), "ArgoCD URL is missing")
 }
 
 func TestSetAppInstanceIdAnnotationNotFound(t *testing.T) {